Conversation
| /// Returns the iceberg schema of the refs table. | ||
| pub fn schema(&self) -> crate::spec::Schema { | ||
| let fields = vec![ | ||
| NestedField::required(1, "name", Type::Primitive(PrimitiveType::String)), |
There was a problem hiding this comment.
Is there any value in adding docs for each field?
| Arc::new(max_snapshot_age_in_ms.finish()), | ||
| ])?; | ||
|
|
||
| Ok(stream::iter(vec![Ok(batch)]).boxed()) |
There was a problem hiding this comment.
I don't expect Refs to be particularly large, but is there a reason to not make this an actual stream that can read back the data incrementally (seems like it would be not that much more effort).
There was a problem hiding this comment.
I 100% agree, and I think long term the goal is to replace a lot of the pyiceberg impl with the rust one so this is something we should tackle in pyiceberg too... defaulting to lazy iterators should be the default but unfortunately is a user breaking change.
https://github.com/apache/iceberg-python/blob/main/pyiceberg/table/inspect.py
Also related:
Would be great to get some momentum on those
There was a problem hiding this comment.
Sorry for the late reply, maybe we can at least add a note here? Or maybe the collection could happen on the python side?
| ], | ||
| min_snapshots_to_keep: PrimitiveArray<Int32> | ||
| [ | ||
| null, |
There was a problem hiding this comment.
for this and max_snapshot_age_in_ms, it seems like it would be good to have test coverage when the value is present, to differentiate tags from branchs
emkornfield
left a comment
emkornfield
left a comment
There was a problem hiding this comment.
New to the code base and reviews so please take comments with a grain of salt.
2 participants
Which issue does this PR close?
Subtask for #823
What changes are included in this PR?
Adds a
refstable to theinspectAre these changes tested?
Added a unit test.
I am pretty terrible at rust so far but think it is generally valuable to start implementing things here so we can roll wheels for the python implementation. Hoping to learn!